Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable userId segment if visitor profile is disabled #21218

Merged
merged 2 commits into from
Sep 4, 2023
Merged

Disable userId segment if visitor profile is disabled #21218

merged 2 commits into from
Sep 4, 2023

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Sep 4, 2023

Description:

fixes #21137

Review

@sgiehl sgiehl added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Needs Review PRs that need a code review labels Sep 4, 2023
@sgiehl sgiehl added this to the 5.0.0 milestone Sep 4, 2023
bx80
bx80 approved these changes Sep 4, 2023
View reviewed changes
Copy link
Contributor

@bx80 bx80 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, I can't see any issues with the code, the new tests pass and user id segments are disabled when checked with breakpoint testing 👍

@bx80 bx80 merged commit 4fc395e into 5.x-dev Sep 4, 2023
@bx80 bx80 deleted the m21137 branch September 4, 2023 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bx80 bx80 bx80 approved these changes

Assignees
No one assigned
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
5.0.0
Development

Successfully merging this pull request may close these issues.

User ID segment is available when visitor profile is disabled
2 participants
@sgiehl @bx80